linux-kernel - Re: Add Apple M1 support to PASemi i2c driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1B71F6A3-6467-46EF-858F-82E93D54365D@xenosoft.de>
Date:   Mon, 4 Oct 2021 11:47:57 +0200
From:   Christian Zigotzky <chzigotzky@...osoft.de>
To:     Sven Peter <sven@...npeter.dev>
Cc:     Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Olof Johansson <olof@...om.net>, Arnd Bergmann <arnd@...db.de>,
        Hector Martin <marcan@...can.st>,
        mohamed.mediouni@...amail.com, Stan Skowronek <stan@...ellium.com>,
        Mark Kettenis <mark.kettenis@...all.nl>,
        linux-arm-kernel@...ts.infradead.org,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        linux-i2c@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "R.T.Dickinson" <rtd2@...a.co.nz>,
        Darren Stevens <darren@...vens-zone.net>,
        Matthew Leaman <matthew@...on.biz>,
        "R.T.Dickinson" <rtd@...on.com>
Subject: Re: Add Apple M1 support to PASemi i2c driver

Hi Sven,

Unfortunately Damien has found an issue. [1]

Output of i2cdetect -l with the default RC3 of kernel 5.15 without your modifications:

2c-0	i2c       	Radeon i2c bit bus 0x90         	I2C adapter
i2c-1	i2c       	Radeon i2c bit bus 0x91         	I2C adapter
i2c-2	i2c       	Radeon i2c bit bus 0x92         	I2C adapter
i2c-3	i2c       	Radeon i2c bit bus 0x93         	I2C adapter
i2c-4	i2c       	Radeon i2c bit bus 0x94         	I2C adapter
i2c-5	i2c       	Radeon i2c bit bus 0x95         	I2C adapter
i2c-6	i2c       	Radeon i2c bit bus 0x96         	I2C adapter
i2c-7	i2c       	Radeon i2c bit bus 0x97         	I2C adapter
i2c-8	i2c       	PA Semi SMBus adapter at 0x800200	I2C adapter
i2c-9	i2c       	PA Semi SMBus adapter at 0x800240	I2C adapter
i2c-10	i2c       	PA Semi SMBus adapter at 0x800280	I2C adapter

Output of i2cdetect -l with your modifications:

i2c-0	i2c       	Radeon i2c bit bus 0x90         	I2C adapter
i2c-1	i2c       	Radeon i2c bit bus 0x91         	I2C adapter
i2c-2	i2c       	Radeon i2c bit bus 0x92         	I2C adapter
i2c-3	i2c       	Radeon i2c bit bus 0x93         	I2C adapter
i2c-4	i2c       	Radeon i2c bit bus 0x94         	I2C adapter
i2c-5	i2c       	Radeon i2c bit bus 0x95         	I2C adapter
i2c-6	i2c       	Radeon i2c bit bus 0x96         	I2C adapter
i2c-7	i2c       	Radeon i2c bit bus 0x97         	I2C adapter
i2c-8	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
i2c-9	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
i2c-10	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter

Please check the outputs.

Thanks,
Christian

[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54165#p54165