linux-kernel - Re: Add Apple M1 support to PASemi i2c driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2760x4OYbNBuFCv32Tgt7K3MdJna4qXvPchdKhV8-8vQ@mail.gmail.com>
Date:   Mon, 4 Oct 2021 13:20:23 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Wolfram Sang <wsa@...nel.org>,
        Christian Zigotzky <chzigotzky@...osoft.de>,
        Sven Peter <sven@...npeter.dev>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Olof Johansson <olof@...om.net>, Arnd Bergmann <arnd@...db.de>,
        Hector Martin <marcan@...can.st>,
        Mohamed Mediouni <mohamed.mediouni@...amail.com>,
        Stan Skowronek <stan@...ellium.com>,
        Mark Kettenis <mark.kettenis@...all.nl>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "R.T.Dickinson" <rtd2@...a.co.nz>,
        Darren Stevens <darren@...vens-zone.net>,
        Matthew Leaman <matthew@...on.biz>,
        "R.T.Dickinson" <rtd@...on.com>
Subject: Re: Add Apple M1 support to PASemi i2c driver

On Mon, Oct 4, 2021 at 11:55 AM Wolfram Sang <wsa@...nel.org> wrote:
>
>
> > i2c-8 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
> > i2c-9 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
> > i2c-10        i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
>
> As Sven correctly switched from %lx to %p, this is intended behaviour.
> Run 'i2cdetect' as root to see the values again.

I think the address could just get removed here, as this is clearly not helpful.
port number, which is somewhat useful for identifying the device, now
it's either the pointless string, or the virtual address that the
device is mapped
to, which is not helpful either and potentially leaks information about kernel
internal structures.

       Arnd