lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 4 Oct 2021 05:38:02 +0000 From: Hyeonggon Yoo <42.hyeyoo@...il.com> To: linux-mm@...ck.org Cc: linux-kernel@...r.kernel.org, Christoph Lameter <cl@...ux.com>, Pekka Enberg <penberg@...nel.org>, David Rientjes <rientjes@...gle.com>, Joonsoo Kim <iamjoonsoo.kim@....com>, Andrew Morton <akpm@...ux-foundation.org>, Vlastimil Babka <vbabka@...e.cz> Subject: Re: [RFC PATCH] mm, slab: Reduce space complexity of alien_cache using rbtree On Sun, Oct 03, 2021 at 05:17:50AM +0000, Hyeonggon Yoo wrote: > + for (i = 0; i < alc_ptr->capacity; i++) { > + alc_ptr->pool[i] = kmalloc_node(sizeof(struct alien_object), gfp, node); > + if (!alc_ptr->pool) { There is mistake - the condition is (!alc_ptr->pool[i]). > + for (i = i - 1; i >= 0; i--) > + kfree(alc_ptr->pool[i]); > + kfree(alc_ptr->pool); > kfree(alc_ptr); > return NULL; > } > } Anyway, I want to hear other's opinions. Is this trade-off sounds affordable to you?
Powered by blists - more mailing lists