linux-kernel - Re: [PATCH] spi: cadence: fix static checker warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Oct 2021 09:49:20 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Parshuram Thombare <pthombar@...ence.com>
Cc:     broonie@...nel.org, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, jpawar@...ence.com,
        mparab@...ence.com
Subject: Re: [PATCH] spi: cadence: fix static checker warning

On Sun, Oct 03, 2021 at 09:04:18AM +0200, Parshuram Thombare wrote:
> This patch fixes Smatch static checker warning.
> CDNS_XSPI_CMD_REG_5 is used in ACMD mode and currently
> only STIG mode is enabled which doesn't use CDNS_XSPI_CMD_REG_5
> and hence everything was working in STIG mode.
> Since plan is to use same function cdns_xspi_trigger_command()
> in ACMD mode, increasing size of the array passed to it.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Link: https://lore.kernel.org/linux-spi/20210930134231.GA14363@kili/ 
> Signed-off-by: Parshuram Thombare <pthombar@...ence.com>

Thanks!  There are runtime tools which will detect this read overflow
so let's add a Fixes tag.

Fixes: a16cc8077627 ("spi: cadence: add support for Cadence XSPI controller")

regards,
dan carpenter