linux-kernel - Re: [PATCH v3] ath10k: Don't always treat modem stop events as crashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue,  5 Oct 2021 14:26:51 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     linux-kernel@...r.kernel.org, ath10k@...ts.infradead.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        Youghandhar Chintala <youghand@...eaurora.org>,
        Abhishek Kumar <kuabhs@...omium.org>,
        Steev Klimaszewski <steev@...i.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Rakesh Pillai <pillair@...eaurora.org>
Subject: Re: [PATCH v3] ath10k: Don't always treat modem stop events as
 crashes

Stephen Boyd <swboyd@...omium.org> wrote:

> When rebooting on sc7180 Trogdor devices I see the following crash from
> the wifi driver.
> 
>  ath10k_snoc 18800000.wifi: firmware crashed! (guid 83493570-29a2-4e98-a83e-70048c47669c)
> 
> This is because a modem stop event looks just like a firmware crash to
> the driver, the qmi connection is closed in both cases. Use the qcom ssr
> notifier block to stop treating the qmi connection close event as a
> firmware crash signal when the modem hasn't actually crashed. See
> ath10k_qmi_event_server_exit() for more details.
> 
> This silences the crash message seen during every reboot.
> 
> Fixes: 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990")
> Cc: Youghandhar Chintala <youghand@...eaurora.org>
> Cc: Abhishek Kumar <kuabhs@...omium.org>
> Cc: Steev Klimaszewski <steev@...i.org>
> Cc: Matthias Kaehlcke <mka@...omium.org>
> Cc: Rakesh Pillai <pillair@...eaurora.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> Reviewed-by: Rakesh Pillai <pillair@...eaurora.org>
> Tested-By: Youghandhar Chintala <youghand@...eaurora.org>
> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

747ff7d3d742 ath10k: Don't always treat modem stop events as crashes

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210922233341.182624-1-swboyd@chromium.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches