lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 5 Oct 2021 19:29:12 +0200
From:   Borislav Petkov <>
To:     "Kuppuswamy, Sathyanarayanan" 
Cc:     Sathyanarayanan Kuppuswamy Natarajan 
        Randy Dunlap <>,
        Thomas Gleixner <>,
        Ingo Molnar <>,,
        Paolo Bonzini <>,
        David Hildenbrand <>,
        Andrea Arcangeli <>,
        Josh Poimboeuf <>,
        Juergen Gross <>, Deep Shah <>,
        VMware Inc <>,
        Vitaly Kuznetsov <>,
        Wanpeng Li <>,
        Jim Mattson <>,
        Joerg Roedel <>, Peter H Anvin <>,
        Dave Hansen <>,
        Tony Luck <>,
        Dan Williams <>,
        Andi Kleen <>,
        Kirill Shutemov <>,
        Sean Christopherson <>,
        Linux Kernel Mailing List <>
Subject: Re: [PATCH v8 02/11] x86/tdx: Introduce INTEL_TDX_GUEST config option

On Tue, Oct 05, 2021 at 07:48:25AM -0700, Kuppuswamy, Sathyanarayanan wrote:
> Since x2APIC will always exist in TDX guest case, we have used select to
> enable the support. But since we have dependency on it, I  think "depends"
> might be a better choice.

Right, and while we're on the subject, this looks silly to me too:

+       depends on SECURITY


  │ Type  : bool
  │ Defined at security/lockdown/Kconfig:1
  │   Prompt: Basic module for enforcing kernel lockdown
  │   Depends on: SECURITY [=n]

so that symbol already depends on SECURITY.

And I have SECURITY=n in my config so I still have to go select SECURITY
by hand so that CONFIG_INTEL_TDX_GUEST becomes visible. And when I
select it, SECURITY_LOCKDOWN_LSM gets enabled too.

But since I have to go select SECURITY, I can just as well enable
SECURITY_LOCKDOWN_LSM in order to have TDX guest support.

IOW, I don't see the point for the evil "select"s - just make everything
depends on and be done with it.

Unless there's an aspect I'm missing...



Powered by blists - more mailing lists