lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Oct 2021 12:59:27 -0700 From: Kees Cook <keescook@...omium.org> To: Luis Chamberlain <mcgrof@...nel.org> Cc: tj@...nel.org, gregkh@...uxfoundation.org, akpm@...ux-foundation.org, minchan@...nel.org, jeyu@...nel.org, shuah@...nel.org, bvanassche@....org, dan.j.williams@...el.com, joe@...ches.com, tglx@...utronix.de, rostedt@...dmis.org, linux-spdx@...r.kernel.org, linux-doc@...r.kernel.org, linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v8 07/12] fs/kernfs/symlink.c: replace S_IRWXUGO with 0777 on kernfs_create_link() On Mon, Sep 27, 2021 at 09:38:00AM -0700, Luis Chamberlain wrote: > If one ends up extending this line checkpatch will complain about the > use of S_IRWXUGO suggesting it is not preferred and that 0777 > should be used instead. Take the tip from checkpatch and do that > change before we do our subsequent changes. > > This makes no functional changes. > > Signed-off-by: Luis Chamberlain <mcgrof@...nel.org> Reviewed-by: Kees Cook <keescook@...omium.org> > --- > fs/kernfs/symlink.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/kernfs/symlink.c b/fs/kernfs/symlink.c > index c8f8e41b8411..19a6c71c6ff5 100644 > --- a/fs/kernfs/symlink.c > +++ b/fs/kernfs/symlink.c > @@ -36,8 +36,7 @@ struct kernfs_node *kernfs_create_link(struct kernfs_node *parent, > gid = target->iattr->ia_gid; > } > > - kn = kernfs_new_node(parent, name, S_IFLNK|S_IRWXUGO, uid, gid, > - KERNFS_LINK); > + kn = kernfs_new_node(parent, name, S_IFLNK|0777, uid, gid, KERNFS_LINK); > if (!kn) > return ERR_PTR(-ENOMEM); > > -- > 2.30.2 > -- Kees Cook
Powered by blists - more mailing lists