linux-kernel - Re: [PATCH 4/7] arm64: dts: apple: t8103: Rename clk24 to clkref

Open Source and information security mailing list archives

Message-ID: <d3ca3c03afb34abe@bloch.sibelius.xs4all.nl>
Date:   Tue, 5 Oct 2021 22:22:32 +0200 (CEST)
From:   Mark Kettenis <mark.kettenis@...all.nl>
To:     Hector Martin <marcan@...can.st>
Cc:     linux-arm-kernel@...ts.infradead.org, marcan@...can.st,
        maz@...nel.org, robh+dt@...nel.org, arnd@...nel.org,
        linus.walleij@...aro.org, alyssa@...enzweig.io, krzk@...nel.org,
        gregkh@...uxfoundation.org, p.zabel@...gutronix.de,
        rafael@...nel.org, devicetree@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 4/7] arm64: dts: apple: t8103: Rename clk24 to clkref

> From: Hector Martin <marcan@...can.st>
> Date: Wed,  6 Oct 2021 00:59:20 +0900
> Content-Type: text/plain; charset="us-ascii"
> 
> We now know that this frequency comes from the external reference
> oscillator and is used for various SoC blocks, and isn't just a random
> 24MHz clock, so let's call it something more appropriate.
> 
> Signed-off-by: Hector Martin <marcan@...can.st>
> ---
>  arch/arm64/boot/dts/apple/t8103.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Mark Kettenis <kettenis@...nbsd.org>

> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
> index a1e22a2ea2e5..9f60f9e48ea0 100644
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
> @@ -95,11 +95,11 @@ timer {
>  			     <AIC_FIQ AIC_TMR_HV_VIRT IRQ_TYPE_LEVEL_HIGH>;
>  	};
>  
> -	clk24: clock-24m {
> +	clkref: clock-ref {
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
>  		clock-frequency = <24000000>;
> -		clock-output-names = "clk24";
> +		clock-output-names = "clkref";
>  	};
>  
>  	soc {
> @@ -120,7 +120,7 @@ serial0: serial@...200000 {
>  			 * TODO: figure out the clocking properly, there may
>  			 * be a third selectable clock.
>  			 */
> -			clocks = <&clk24>, <&clk24>;
> +			clocks = <&clkref>, <&clkref>;
>  			clock-names = "uart", "clk_uart_baud0";
>  			status = "disabled";
>  		};
> -- 
> 2.33.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives