linux-kernel - Re: [PATCH v8 02/11] x86/tdx: Introduce INTEL_TDX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6682234f-06d8-1e66-07e6-446358e2e181@intel.com>
Date:   Tue, 5 Oct 2021 13:42:22 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, Paolo Bonzini <pbonzini@...hat.com>,
        David Hildenbrand <david@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Juergen Gross <jgross@...e.com>, Deep Shah <sdeep@...are.com>,
        VMware Inc <pv-drivers@...are.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, Peter H Anvin <hpa@...or.com>,
        Tony Luck <tony.luck@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 02/11] x86/tdx: Introduce INTEL_TDX_GUEST config option

On 10/5/21 1:33 PM, Sean Christopherson wrote:
> On Tue, Oct 05, 2021, Josh Poimboeuf wrote:
>> On Mon, Oct 04, 2021 at 07:51:56PM -0700, Kuppuswamy Sathyanarayanan wrote:
>>> +config INTEL_TDX_GUEST
>>> +	bool "Intel Trusted Domain eXtensions Guest Support"
>> ...
>>
>>> +	  Provide support for running in a trusted domain on Intel processors
>>> +	  equipped with Trusted Domain eXtensions. TDX is a Intel technology
>> I haven't seen this particular punctuation "eXtensions" anywhere.  Intel
>> documentation writes it as "Extensions".  Better to be consistent.

It's less about what Intel calls it and more defining acronyms by
capitalizing the letters used in the acronym.  This:

	git log -p arch/x86/ | grep eXtension

shows at least SGX and MPX in the past have done the "eXtension" thing.

So, yes, please pick one.  But, don't throw out "eXtension" because it
hasn't been used before.  It has.  I'd also advise against using the
Intel documentation as gospel here.  It's *not* a good example to
blindly follow.