lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 6 Oct 2021 00:16:50 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 9/9] staging: r8188eu: support interface is always usb

On 10/5/21 22:08, Martin Kaiser wrote:
> We set ODM_CMNINFO_INTERFACE to ODM_ITRF_USB as this driver supports
> only usb. Therefore, dm_odm->SupportInterface is always ODM_ITRF_USB.
> 
> Simplify some if conditions accordingly. Remove/replace two empty
> functions.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>   drivers/staging/r8188eu/hal/odm_HWConfig.c | 58 +++++++---------------
>   1 file changed, 19 insertions(+), 39 deletions(-)
> 

<...>

>   
>   static s32 odm_SignalScaleMapping(struct odm_dm_struct *dm_odm, s32 CurrSig)
>   {
> -	if ((dm_odm->SupportPlatform == ODM_MP) &&
> -	    (dm_odm->SupportInterface != ODM_ITRF_PCIE) && /* USB & SDIO */
> -	    (dm_odm->PatchID == 10))
> -		return odm_sig_patch_netcore(dm_odm, CurrSig);
> -	else if ((dm_odm->SupportPlatform == ODM_MP) &&
> -		 (dm_odm->SupportInterface == ODM_ITRF_PCIE) &&
> -		 (dm_odm->PatchID == 19))
> -		return odm_sig_patch_lenove(dm_odm, CurrSig);
> +	if ((dm_odm->SupportPlatform == ODM_MP) && (dm_odm->PatchID == 10))
> +		return 0;
>   	else
>   		return odm_SignalScaleMapping_92CSeries(dm_odm, CurrSig);
>   }
> 

dm_odm->SupportPlatform is always ODM_CE, so this could be just:

	return odm_SignalScaleMapping_92CSeries(dm_odm, CurrSig);

And then it's just an unnecessary wrapper. ;)

Regards,
Michael

Powered by blists - more mailing lists