linux-kernel - [PATCH] usb: musb: select GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue,  5 Oct 2021 16:57:47 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>, Bin Liu <b-liu@...com>,
        Min Guo <min.guo@...iatek.com>,
        Yonglong Wu <yonglong.wu@...iatek.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-mediatek@...ts.infradead.org
Subject: [PATCH] usb: musb: select GENERIC_PHY instead of depending on it

The kconfig symbol GENERIC_PHY says:
  All the users of this framework should select this config.
and around 136 out of 138 drivers do so, so change USB_MUSB_MEDIATEK
to do so also.

This (also) fixes a long circular dependency problem for an upcoming
patch.

Fixes: 0990366bab3c ("usb: musb: Add support for MediaTek musb controller")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Bin Liu <b-liu@...com>
Cc: Min Guo <min.guo@...iatek.com>
Cc: Yonglong Wu <yonglong.wu@...iatek.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-mediatek@...ts.infradead.org
---
Applies to mainline.

 drivers/usb/musb/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20211005.orig/drivers/usb/musb/Kconfig
+++ linux-next-20211005/drivers/usb/musb/Kconfig
@@ -120,7 +120,7 @@ config USB_MUSB_MEDIATEK
 	tristate "MediaTek platforms"
 	depends on ARCH_MEDIATEK || COMPILE_TEST
 	depends on NOP_USB_XCEIV
-	depends on GENERIC_PHY
+	select GENERIC_PHY
 	select USB_ROLE_SWITCH
 
 comment "MUSB DMA mode"