lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Oct 2021 08:39:32 +0200 From: Amelie DELAUNAY <amelie.delaunay@...s.st.com> To: Randy Dunlap <rdunlap@...radead.org>, <linux-kernel@...r.kernel.org> CC: Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Amelie Delaunay <amelie.delaunay@...com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org> Subject: Re: [PATCH] usb: typec: STUSB160X should select REGMAP_I2C On 10/5/21 1:21 AM, Randy Dunlap wrote: > REGMAP_I2C is not a user visible kconfig symbol so driver configs > should not "depend on" it. They should depend on I2C and then > select REGMAP_I2C. > > If this worked, it was only because some other driver had set/enabled > REGMAP_I2C. > > Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family") > Signed-off-by: Randy Dunlap <rdunlap@...radead.org> Thanks for your patch. Reviewed-by: Amelie Delaunay <amelie.delaunay@...s.st.com> > Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com> > Cc: Amelie Delaunay <amelie.delaunay@...com> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org> > Cc: linux-usb@...r.kernel.org > --- > drivers/usb/typec/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- lnx-515-rc4.orig/drivers/usb/typec/Kconfig > +++ lnx-515-rc4/drivers/usb/typec/Kconfig > @@ -65,9 +65,9 @@ config TYPEC_HD3SS3220 > > config TYPEC_STUSB160X > tristate "STMicroelectronics STUSB160x Type-C controller driver" > - depends on I2C > - depends on REGMAP_I2C > depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH > + depends on I2C > + select REGMAP_I2C > help > Say Y or M here if your system has STMicroelectronics STUSB160x > Type-C port controller. >
Powered by blists - more mailing lists