linux-kernel - [PATCH] s390: Fix strrchr() implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211005072621.53500-1-roberto.sassu@huawei.com>
Date:   Tue, 5 Oct 2021 09:26:21 +0200
From:   Roberto Sassu <roberto.sassu@...wei.com>
To:     <hca@...ux.ibm.com>, <gor@...ux.ibm.com>, <borntraeger@...ibm.com>
CC:     <linux-s390@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Roberto Sassu <roberto.sassu@...wei.com>
Subject: [PATCH] s390: Fix strrchr() implementation

Access the string at len - 1 instead of len.

Signed-off-by: Roberto Sassu <roberto.sassu@...wei.com>
---
 arch/s390/lib/string.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/s390/lib/string.c b/arch/s390/lib/string.c
index cfcdf76d6a95..162a391788ad 100644
--- a/arch/s390/lib/string.c
+++ b/arch/s390/lib/string.c
@@ -261,12 +261,12 @@ char *strrchr(const char *s, int c)
 {
        size_t len = __strend(s) - s;
 
-       if (len)
-	       do {
-		       if (s[len] == (char) c)
-			       return (char *) s + len;
-	       } while (--len > 0);
-       return NULL;
+	if (len)
+		do {
+			if (s[len - 1] == (char) c)
+				return (char *) s + len - 1;
+		} while (--len > 0);
+	return NULL;
 }
 EXPORT_SYMBOL(strrchr);
 #endif
-- 
2.32.0