[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6f45ee92-d0cb-92d5-a7db-3466af3e13d8@nvidia.com>
Date: Tue, 5 Oct 2021 08:43:37 +0100
From: Jon Hunter <jonathanh@...dia.com>
To: Akhil R <akhilrajeev@...dia.com>
CC: <dan.j.williams@...el.com>, <dmaengine@...r.kernel.org>,
<kyarlagadda@...dia.com>, <ldewangan@...dia.com>,
<linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
<p.zabel@...gutronix.de>, <rgumasta@...dia.com>,
<thierry.reding@...il.com>, <vkoul@...nel.org>
Subject: Re: [PATCH v8 0/4] Add Nvidia Tegra GPC-DMA driver
On 27/09/2021 17:11, Akhil R wrote:
> Add support for Nvida Tegra general purpose DMA driver for
> Tegra186 and Tegra194 platform.
>
> Changes in patch v8:
> * Fixed dt_binding_check errors in binding doc .
> * Updated get_burst_size and dma_tx_status functions.
> * Removed slave_id assigning in tegra_dma_slave_config
> * dt node name changed from dma to dma-controller
>
> v6..v7 - https://lkml.org/lkml/2021/9/17/652
> v2..v5 - https://lkml.org/lkml/2021/9/16/455
> v1 - https://lkml.org/lkml/2020/7/20/96
>
> Akhil R (4):
> dt-bindings: dmaengine: Add doc for tegra gpcdma
> dmaengine: tegra: Add tegra gpcdma driver
> arm64: defconfig: tegra: Enable GPCDMA
> arm64: tegra: Add GPCDMA node for tegra186 and tegra194
>
> .../bindings/dma/nvidia,tegra186-gpc-dma.yaml | 108 ++
> arch/arm64/boot/dts/nvidia/tegra186-p3310.dtsi | 4 +
> arch/arm64/boot/dts/nvidia/tegra186.dtsi | 44 +
> arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 4 +
> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 44 +
> arch/arm64/configs/defconfig | 1 +
> drivers/dma/Kconfig | 12 +
> drivers/dma/Makefile | 1 +
> drivers/dma/tegra186-gpc-dma.c | 1298 ++++++++++++++++++++
> 9 files changed, 1516 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> create mode 100644 drivers/dma/tegra186-gpc-dma.c
For the series ...
Reviewed-by: Jon Hunter <jonathanh@...dia.com>
I have a couple minor comments, but otherwise it is fine.
Jon
--
nvpublic
Powered by blists - more mailing lists