linux-kernel - Re: [PATCH v2 RESEND] mfd: hi6421-spmi-pmic: cleanup drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YVwD2sPZMCtwP9yf@google.com>
Date:   Tue, 5 Oct 2021 08:50:50 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     linuxarm@...wei.com, mauro.chehab@...wei.com,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 RESEND] mfd: hi6421-spmi-pmic: cleanup drvdata

On Wed, 15 Sep 2021, Mauro Carvalho Chehab wrote:

> There are lots of fields at struct hi6421_spmi_pmic that aren't
> used. In a matter of fact, only regmap is needed.
> 
> So, drop the struct as a hole, and set just the regmap as
> the drvdata.
> 
> Acked-by: Mark Brown <broonie@...nel.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
>  drivers/mfd/hi6421-spmi-pmic.c           | 16 +++++----------
>  drivers/misc/hi6421v600-irq.c            |  9 ++++-----
>  drivers/regulator/hi6421v600-regulator.c | 10 +++++-----
>  include/linux/mfd/hi6421-spmi-pmic.h     | 25 ------------------------
>  4 files changed, 14 insertions(+), 46 deletions(-)
>  delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h

For my own reference (apply this as-is to your sign-off block):

  Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>

I intend to take this with a Misc Ack.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog