Message-ID: <20211005083256.GB15539@xsang-OptiPlex-9020>
Date:   Tue, 5 Oct 2021 16:32:56 +0800
From:   kernel test robot <oliver.sang@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Sebastian Siewior <bigeasy@...utronix.de>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org,
        lkp@...el.com
Subject: [net]  2dcb96bacc: WARNING:possible_recursive_locking_detected



Greeting,

FYI, we noticed the following commit (built with gcc-9):

commit: 2dcb96bacce36021c2f3eaae0cef607b5bb71ede ("net: core: Correct the sock::sk_lock.owned lockdep annotations")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master


in testcase: kernel-selftests
version: kernel-selftests-x86_64-c8c9111a-1_20210929
with following parameters:

	group: mptcp
	ucode: 0xe2

test-description: The kernel contains a set of "self tests" under the tools/testing/selftests/ directory. These are intended to be small unit tests to exercise individual code paths in the kernel.
test-url: https://www.kernel.org/doc/Documentation/kselftest.txt


on test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz with 32G memory

caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):



If you fix the issue, kindly add following tag
Reported-by: kernel test robot <oliver.sang@...el.com>



[  476.022917][T19213]
[  476.025095][T19213] ============================================
[  476.031073][T19213] WARNING: possible recursive locking detected
[  476.037049][T19213] 5.15.0-rc1-00132-g2dcb96bacce3 #1 Not tainted
[  476.043115][T19213] --------------------------------------------
[  476.049090][T19213] pm_nl_ctl/19213 is trying to acquire lock:
[  476.054893][T19213] ffff888813815b20 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: mptcp_close+0xbe/0x300
[  476.063639][T19213]
[  476.063639][T19213] but task is already holding lock:
[  476.070825][T19213] ffff88880a636ca0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: mptcp_close+0x1c/0x300
[  476.079569][T19213]
[  476.079569][T19213] other info that might help us debug this:
[  476.087444][T19213]  Possible unsafe locking scenario:
[  476.087444][T19213]
[  476.094730][T19213]        CPU0
[  476.097852][T19213]        ----
[  476.100977][T19213]   lock(k-sk_lock-AF_INET);
[  476.105396][T19213]   lock(k-sk_lock-AF_INET);
[  476.109817][T19213]
[  476.109817][T19213]  *** DEADLOCK ***
[  476.109817][T19213]
[  476.117778][T19213]  May be due to missing lock nesting notation
[  476.117778][T19213]
[  476.125913][T19213] 3 locks held by pm_nl_ctl/19213:
[  476.130853][T19213]  #0: ffffffff83937b50 (cb_lock){++++}-{3:3}, at: genl_rcv+0x15/0x40
[  476.138819][T19213]  #1: ffffffff83937be8 (genl_mutex){+.+.}-{3:3}, at: genl_rcv_msg+0x11c/0x200
[  476.147564][T19213]  #2: ffff88880a636ca0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: mptcp_close+0x1c/0x300
[  476.156765][T19213]
[  476.156765][T19213] stack backtrace:
[  476.162490][T19213] CPU: 0 PID: 19213 Comm: pm_nl_ctl Not tainted 5.15.0-rc1-00132-g2dcb96bacce3 #1
[  476.171506][T19213] Hardware name: Dell Inc. OptiPlex 7040/0Y7WYT, BIOS 1.8.1 12/05/2017
[  476.179568][T19213] Call Trace:
[  476.182695][T19213]  dump_stack_lvl+0x45/0x59
[  476.187031][T19213]  validate_chain.cold+0x124/0x155
[  476.191971][T19213]  ? register_lock_class+0x45/0x7c0
[  476.196999][T19213]  __lock_acquire+0x57e/0xb00
[  476.201510][T19213]  lock_acquire+0xca/0x300
[  476.205769][T19213]  ? mptcp_close+0xbe/0x300
[  476.210118][T19213]  ? lock_is_held_type+0xd5/0x140
[  476.214971][T19213]  lock_sock_fast+0x30/0x80
[  476.219306][T19213]  ? mptcp_close+0xbe/0x300
[  476.223643][T19213]  mptcp_close+0xbe/0x300
[  476.227806][T19213]  inet_release+0x3f/0x80
[  476.231971][T19213]  __sock_release+0x88/0xc0
[  476.236304][T19213]  __mptcp_pm_release_addr_entry+0x17/0x40
[  476.241938][T19213]  mptcp_nl_cmd_del_addr+0x351/0x480
[  476.247052][T19213]  ? genl_family_rcv_msg_doit+0xef/0x180
[  476.253117][T19213]  genl_family_rcv_msg_doit+0xef/0x180
[  476.259010][T19213]  genl_rcv_msg+0xe0/0x200
[  476.263258][T19213]  ? mptcp_pm_remove_anno_addr+0xc0/0xc0
[  476.268735][T19213]  ? genl_family_rcv_msg_doit+0x180/0x180
[  476.274886][T19213]  netlink_rcv_skb+0x50/0x100
[  476.279397][T19213]  genl_rcv+0x24/0x40
[  476.283211][T19213]  netlink_unicast+0x191/0x240
[  476.287807][T19213]  netlink_sendmsg+0x243/0x480
[  476.292403][T19213]  sock_sendmsg+0x5e/0x80
[  476.296566][T19213]  __sys_sendto+0xf4/0x180
[  476.300818][T19213]  ? lock_is_held_type+0xd5/0x140
[  476.305670][T19213]  ? syscall_enter_from_user_mode+0x21/0x80
[  476.311388][T19213]  __x64_sys_sendto+0x25/0x40
[  476.315894][T19213]  do_syscall_64+0x5c/0x80
[  476.320146][T19213]  ? up_read+0x17/0x240
[  476.324132][T19213]  ? lock_is_held_type+0xd5/0x140
[  476.328987][T19213]  ? asm_exc_page_fault+0x8/0x30
[  476.333753][T19213]  ? asm_exc_page_fault+0x1e/0x30
[  476.338619][T19213]  ? asm_exc_page_fault+0x8/0x30
[  476.343388][T19213]  ? lockdep_hardirqs_on+0x79/0x100
[  476.348413][T19213]  entry_SYSCALL_64_after_hwframe+0x44/0xae
[  476.354131][T19213] RIP: 0033:0x7f6fec8189b7
[  476.358381][T19213] Code: 64 89 02 48 c7 c0 ff ff ff ff eb b6 0f 1f 80 00 00 00 00 48 8d 05 49 5d 0c 00 41 89 ca 8b 00 85 c0 75 10 b8 2c 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 71 c3 41 57 4d 89 c7 41 56 41 89 ce 41 55 49
[  476.377781][T19213] RSP: 002b:00007ffcc2240758 EFLAGS: 00000246 ORIG_RAX: 000000000000002c
[  476.386005][T19213] RAX: ffffffffffffffda RBX: 00007ffcc22407b0 RCX: 00007f6fec8189b7
[  476.393805][T19213] RDX: 0000000000000020 RSI: 00007ffcc22407b0 RDI: 0000000000000005
[  476.401606][T19213] RBP: 0000000000000020 R08: 00007ffcc2240764 R09: 000000000000000c
[  476.409410][T19213] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
[  476.417213][T19213] R13: 0000000000000005 R14: 00007ffcc2240764 R15: 0000000000000000




To reproduce:

        git clone https://github.com/intel/lkp-tests.git
        cd lkp-tests
        sudo bin/lkp install job.yaml           # job file is attached in this email
        bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
        sudo bin/lkp run generated-yaml-file

        # if come across any failure that blocks the test,
        # please remove ~/.lkp and /lkp dir to run from a clean state.



---
0DAY/LKP+ Test Infrastructure                   Open Source Technology Center
https://lists.01.org/hyperkitty/list/lkp@lists.01.org       Intel Corporation

Thanks,
Oliver Sang


View attachment "config-5.15.0-rc1-00132-g2dcb96bacce3" of type "text/plain" (176418 bytes)

View attachment "job-script" of type "text/plain" (6242 bytes)

Download attachment "dmesg.xz" of type "application/x-xz" (41968 bytes)

View attachment "kernel-selftests" of type "text/plain" (63209 bytes)

View attachment "job.yaml" of type "text/plain" (5295 bytes)

View attachment "reproduce" of type "text/plain" (158 bytes)

Powered by blists - more mailing lists