linux-kernel - Re: [PATCH v2 RESEND] mfd: hi6421-spmi-pmic: cleanup drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211005104656.22d450b6@coco.lan>
Date:   Tue, 5 Oct 2021 10:46:56 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linuxarm@...wei.com, mauro.chehab@...wei.com,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 RESEND] mfd: hi6421-spmi-pmic: cleanup drvdata

Em Tue, 5 Oct 2021 09:11:06 +0100
Lee Jones <lee.jones@...aro.org> escreveu:

> On Tue, 05 Oct 2021, Mauro Carvalho Chehab wrote:
> 
> > Em Tue, 5 Oct 2021 08:50:50 +0100
> > Lee Jones <lee.jones@...aro.org> escreveu:
> >   
> > > On Wed, 15 Sep 2021, Mauro Carvalho Chehab wrote:
> > >   
> > > > There are lots of fields at struct hi6421_spmi_pmic that aren't
> > > > used. In a matter of fact, only regmap is needed.
> > > > 
> > > > So, drop the struct as a hole, and set just the regmap as
> > > > the drvdata.
> > > > 
> > > > Acked-by: Mark Brown <broonie@...nel.org>
> > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > > > ---
> > > >  drivers/mfd/hi6421-spmi-pmic.c           | 16 +++++----------
> > > >  drivers/misc/hi6421v600-irq.c            |  9 ++++-----
> > > >  drivers/regulator/hi6421v600-regulator.c | 10 +++++-----
> > > >  include/linux/mfd/hi6421-spmi-pmic.h     | 25 ------------------------
> > > >  4 files changed, 14 insertions(+), 46 deletions(-)
> > > >  delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h    
> > > 
> > > For my own reference (apply this as-is to your sign-off block):
> > > 
> > >   Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>
> > > 
> > > I intend to take this with a Misc Ack.  
> > 
> > Hi Lee,
> > 
> > Greg already gave you:
> > 
> > 	https://lore.kernel.org/all/YVLA14jbwqXjNM2f@kroah.com/  
> 
> Yes, I found that after I replied to this one.
> 
> I was having some trouble applying it with `b4` just as you replied:
> 
>   https://lore.kernel.org/tools/CAF2Aj3icJtU+wacosM-LO2aqMChWL69T6bf7dK3xqPMSk6Ux3w@mail.gmail.com/T/#u

Weird. Yeah, getting acks are sometimes problematic. I remember
having issues with that (a long time ago) with patchwork too.

> I fixed the spelling/grammar mistakes and applied the patch.

Thank you!

Best regards,
Mauro