linux-kernel - Re: [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d6fe646-5110-0fba-fc30-0ff7aad6de03@codeaurora.org>
Date:   Tue, 5 Oct 2021 14:23:30 +0530
From:   Maulik Shah <mkshah@...eaurora.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     swboyd@...omium.org, mka@...omium.org, evgreen@...omium.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        agross@...nel.org, dianders@...omium.org, linux@...ck-us.net,
        rnayak@...eaurora.org, lsrao@...eaurora.org,
        Mahesh Sivasubramanian <msivasub@...eaurora.org>,
        devicetree@...r.kernel.org, Lina Iyer <ilina@...eaurora.org>
Subject: Re: [PATCH v9 1/5] dt-bindings: Introduce SoC sleep stats bindings

Hi,

On 9/25/2021 4:53 AM, Bjorn Andersson wrote:
> On Mon 06 Sep 00:27 CDT 2021, Maulik Shah wrote:
> 
>> From: Mahesh Sivasubramanian <msivasub@...eaurora.org>
>>
>> Add device binding documentation for Qualcomm Technologies, Inc. (QTI)
>> SoC sleep stats driver. The driver is used for displaying SoC sleep
>> statistic maintained by Always On Processor or Resource Power Manager.
>>
>> Cc: devicetree@...r.kernel.org
>> Signed-off-by: Mahesh Sivasubramanian <msivasub@...eaurora.org>
>> Signed-off-by: Lina Iyer <ilina@...eaurora.org>
>> Signed-off-by: Maulik Shah <mkshah@...eaurora.org>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>> Reviewed-by: Stephen Boyd <swboyd@...omium.org>
>> ---
>>   .../bindings/soc/qcom/soc-sleep-stats.yaml         | 48 ++++++++++++++++++++++
>>   1 file changed, 48 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
>> new file mode 100644
>> index 0000000..4161156
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml
>> @@ -0,0 +1,48 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings
>> +
>> +maintainers:
>> +  - Maulik Shah <mkshah@...eaurora.org>
>> +  - Lina Iyer <ilina@...eaurora.org>
> 
> Lina's address is no longer valid.

Removed in v10.

> 
>> +
>> +description:
>> +  Always On Processor/Resource Power Manager maintains statistics of the SoC
>> +  sleep modes involving powering down of the rails and oscillator clock.
>> +
>> +  Statistics includes SoC sleep mode type, number of times low power mode were
>> +  entered, time of last entry, time of last exit and accumulated sleep duration.
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - qcom,rpmh-sleep-stats
>> +      - qcom,rpm-sleep-stats
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  # Example of rpmh sleep stats
>> +  - |
>> +    aop_msgram@...0048 {
>> +      compatible = "qcom,rpmh-sleep-stats";
>> +      reg = <0x0c3f0048 0x400>;
> 
> As I tested this series I did find it quite odd that the start address
> of this block is $48 bytes into a page and still the length is an even
> $400.
> 
> Is there any single platform where qcom,rpmh-sleep-stats doesn't start
> at an offset of $48 from the beginning of its msgram? Could we move this
> number to the driver?
> 
> Regards,
> Bjorn

Sure, i have moved 0x48 into driver in v10.

Thanks,
Maulik

> 
>> +    };
>> +  # Example of rpm sleep stats
>> +  - |
>> +    rpm_msgram@...0000 {
>> +      compatible = "qcom,rpm-sleep-stats";
>> +      reg = <0x04690000 0x400>;
>> +    };
>> +...
>> -- 
>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
>> of Code Aurora Forum, hosted by The Linux Foundation
>>

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member of Code Aurora Forum, hosted by The Linux Foundation