lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Oct 2021 12:17:32 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Michael Grzeschik <mgr@...gutronix.de> Cc: Ferry Toth <fntoth@...il.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, USB <linux-usb@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Felipe Balbi <balbi@...nel.org> Subject: Re: [PATCH v1 1/1] usb: dwc3: gadget: Revert "set gadgets parent to the right controller" On Tue, Oct 5, 2021 at 11:52 AM Michael Grzeschik <mgr@...gutronix.de> wrote: > On Mon, Oct 04, 2021 at 10:35:57PM +0200, Ferry Toth wrote: > >Op 04-10-2021 om 16:18 schreef Andy Shevchenko: > >>The commit c6e23b89a95d ("usb: dwc3: gadget: set gadgets parent to the right > >>controller") changed the device for the UDC and broke the user space scripts > >>that instantiate the USB gadget(s) via ConfigFS. > > > >I confirm this regression on Intel Edison since at least 5.15-rc2 > >while in 5.14.0 it was working fine. > > > >This patch resolves the issue as tested on 5.15-rc4. > > > >Tested-by: Ferry Toth<fntoth@...il.com> > > NACK! Why should we resolv an issue by reverting it to solve not working > userspace. Huh?! It is a) used to work; b) stopped working after your commit. To me it's a clear regression. Whatever deeper problem is there, I really don't care. The change broke my _user space_ case! > We already have this patch as a solution for solving a deeper > Problem, regarding the allocator addressing the right device. Then rework it. You have still time. Your case wasn't working and one more release of not working is not an issue here. > >>Revert it for now until the better solution will be proposed. > > So, I think fixing the userspace would be the right fix, Huh?! https://www.kernel.org/doc/html/latest/process/4.Coding.html#regressions > not changing > the kernel. Otherwise we should find a proper solution. So, please do. v5.15 should still work on our devices with distribution that uses ConfigFS, no? -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists