linux-kernel - Re: [PATCH v1 0/3] serial:8250:Add driver support for MCHP PCI1XXXX UART module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdYqOVNGY7-FdNkTy8hLn-2OWVEZrPuXDYufEC-yOM=BQ@mail.gmail.com>
Date:   Tue, 5 Oct 2021 12:47:47 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     LakshmiPraveen Kopparthi <LakshmiPraveen.Kopparthi@...rochip.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        "Maciej W. Rozycki" <macro@...am.me.uk>,
        Zev Weiss <zev@...ilderbeest.net>, Vignesh R <vigneshr@...com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH v1 0/3] serial:8250:Add driver support for MCHP PCI1XXXX
 UART module

On Tue, Oct 5, 2021 at 11:49 AM LakshmiPraveen Kopparthi
<LakshmiPraveen.Kopparthi@...rochip.com> wrote:
> On Wed, 2021-09-29 at 19:48 +0300, Andy Shevchenko wrote:

...

> > Please, do not add this to 8250_pci.c. Use separate quirk driver as
> > it's done
> > in plenty of examples:
> >
> >         8250_lpss.c, 8250_mid.c, 8250_exar.c, ...
>
> Thanks for pointing the examples. I have looked into these examples and
> the required functionality can be achieved with a separate driver. But
> I would like to know the reason for not adding this to 8250_pci.c.

Maintainability. And we may check, btw, the LOC difference when you
will be ready with a separate driver.
In some cases it would even be a good win.

-- 
With Best Regards,
Andy Shevchenko