lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 05 Oct 2021 15:22:57 +0530
From:   mkrishn@...eaurora.org
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, kalyan_t@...eaurora.org,
        sbillaka@...eaurora.org, abhinavk@...eaurora.org,
        robdclark@...il.com, bjorn.andersson@...aro.org,
        khsieh@...eaurora.org, rajeevny@...eaurora.org,
        freedreno@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        robh+dt@...nel.org
Subject: Re: [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes

On 2021-10-05 07:21, Stephen Boyd wrote:
> Quoting mkrishn@...eaurora.org (2021-09-30 23:39:07)
>> On 2021-09-30 23:28, Stephen Boyd wrote:
>> > Quoting mkrishn@...eaurora.org (2021-09-30 04:56:59)
>> >> On 2021-08-19 01:27, Stephen Boyd wrote:
>> >> > Quoting Krishna Manikandan (2021-08-18 03:27:02)
>> >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> >> >> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> >> >> index 53a21d0..fd7ff1c 100644
>> >> >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> >> >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> >> >> +
>> >> >> +                       status = "disabled";
>> >> >> +
>> >> >> +                       mdp: mdp@...1000 {
>> >> >
>> >> > display-controller@...1000
>> >>
>> >> Stephen,
>> >>     In the current driver code, there is a substring comparison for
>> >> "mdp"
>> >> in device node name as part of probe sequence. If "mdp" is not present
>> >> in the node name, it will
>> >>     return an error resulting in probe failure. Can we continue using
>> >> mdp
>> >> as nodename instead of display controller?
>> >>
>> >
>> > Can we fix the driver to not look for node names and look for
>> > compatible
>> > strings instead? It took me a minute to find compare_name_mdp() in
>> > drivers/gpu/drm/msm/msm_drv.c to understand what you're talking about.
>> > Perhaps looking for qcom,mdp5 in there will be sufficient instead of
>> > looking at the node name.
>> 
>> Sure Stephen. I will make the necessary changes in msm_drv.c to look 
>> for
>> compatible string instead of node name.
>> Can I include these two changes (changing mdp--> display controller 
>> and
>> msm_drv.c changes) in a separate series ?
>> 
> 
> Sure. So you'll send the drm driver change now and we'll get the DT
> change after that with the more generic node name?

Yes Stephen.I have raised the change to fix the driver issue.
https://patchwork.kernel.org/project/linux-arm-msm/patch/1633427071-19523-1-git-send-email-mkrishn@codeaurora.org/

Regards,
Krishna

Powered by blists - more mailing lists