lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 05 Oct 2021 11:54:47 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Florian Fainelli <f.fainelli@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Jim Quinlan <jim2101024@...il.com>,
        "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] reset: brcmstb-rescal: fix incorrect polarity of status
 bit

On Tue, 2021-09-14 at 15:11 -0700, Florian Fainelli wrote:
> From: Jim Quinlan <jim2101024@...il.com>
> 
> The readl_poll_timeout() should complete when the status bit
> is a 1, not 0.
> 
> Fixes: 4cf176e52397 ("reset: Add Broadcom STB RESCAL reset controller")
> Signed-off-by: Jim Quinlan <jim2101024@...il.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  drivers/reset/reset-brcmstb-rescal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/reset-brcmstb-rescal.c b/drivers/reset/reset-brcmstb-rescal.c
> index b6f074d6a65f..433fa0c40e47 100644
> --- a/drivers/reset/reset-brcmstb-rescal.c
> +++ b/drivers/reset/reset-brcmstb-rescal.c
> @@ -38,7 +38,7 @@ static int brcm_rescal_reset_set(struct reset_controller_dev *rcdev,
>  	}
>  
>  	ret = readl_poll_timeout(base + BRCM_RESCAL_STATUS, reg,
> -				 !(reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
> +				 (reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
>  	if (ret) {
>  		dev_err(data->dev, "time out on SATA/PCIe rescal\n");
>  		return ret;

Thank you, applied to reset/fixes.

regards
Philipp

Powered by blists - more mailing lists