linux-kernel - Re: [PATCH v1 4/4] ARM: dts: mvebu: add device tree for netgear gs110emx switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YVxNjc0LrYp4SXtP@lunn.ch>
Date:   Tue, 5 Oct 2021 15:05:17 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Marcel Ziswiler <marcel@...wiler.com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Frank Rowand <frowand.list@...il.com>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Olof Johansson <olof@...om.net>,
        Rob Herring <robh+dt@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        soc@...nel.org
Subject: Re: [PATCH v1 4/4] ARM: dts: mvebu: add device tree for netgear
 gs110emx switch

> +		mdio {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			switch0phy0: switch0phy0@1 {
> +				reg = <0x1>;
> +			};

> +
> +			port@1 {
> +				label = "lan1";
> +				phy-handle = <&switch0phy0>;
> +				reg = <1>;
> +			};

You numbering of the phy labels is a bit confusing here. Both the port
and the PHY use reg=<1>. So i would use the label

switch0phy1: switch0phy1@1 

     Andrew