linux-kernel - Re: [PATCH 2/2] power: supply: max77976: add Maxim MAX77976 charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cce10251-c092-c06b-dbc4-d257bb7aa305@lucaceresoli.net>
Date:   Tue, 5 Oct 2021 15:15:37 +0200
From:   Luca Ceresoli <luca@...aceresoli.net>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-pm@...r.kernel.org
Cc:     Sebastian Reichel <sre@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] power: supply: max77976: add Maxim MAX77976 charger
 driver

Hi Randy,

On 04/10/21 17:28, Randy Dunlap wrote:
> On 10/4/21 6:07 AM, Luca Ceresoli wrote:
>> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
>> index ad93b3550d6d..622d690c883a 100644
>> --- a/drivers/power/supply/Kconfig
>> +++ b/drivers/power/supply/Kconfig
>> @@ -557,6 +557,17 @@ config CHARGER_MAX77693
>>       help
>>         Say Y to enable support for the Maxim MAX77693 battery charger.
>>   +config CHARGER_MAX77976
>> +    tristate "Maxim MAX77976 battery charger driver"
>> +    depends on REGMAP_I2C
>> +    help
>> +      The Maxim MAX77976 is a 19 Vin, 5.5A 1-Cell Li+ Battery Charger
>> +      USB OTG support. It has an I2C interface for configuration.
>> +
>> +      Say Y to enable support for the Maxim MAX77976 battery charger.
>> +      This driver can also be built as a module. If so, the module
>> will be
>> +      called max77976_charger.
> 
> REGMAP_I2C is not a user-settable config option, so drivers should not
> "depend on" it. This should be more like:
> 
>     depends on I2C
>     select REGMAP_I2C

Ouch, thanks for spotting, will fix in v2.

-- 
Luca