linux-kernel - Re: [PATCH] crypto : asymmetric_keys: Fix function description to match prototype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YV3f0gTu/epdCX/E@erythro.dev.benboeckel.internal>
Date:   Wed, 6 Oct 2021 13:41:38 -0400
From:   Ben Boeckel <me@...boeckel.net>
To:     Colin King <colin.king@...onical.com>
Cc:     David Howells <dhowells@...hat.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>, keyrings@...r.kernel.org,
        linux-crypto@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH] crypto : asymmetric_keys: Fix function description to
 match prototype

On Wed, Oct 06, 2021 at 18:23:50 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The function arguments in the description does not match the prototype.
> Fix this by renaming trust_keys to trusted_keys.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  crypto/asymmetric_keys/verify_pefile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_keys/verify_pefile.c
> index 7553ab18db89..148cad70fe79 100644
> --- a/crypto/asymmetric_keys/verify_pefile.c
> +++ b/crypto/asymmetric_keys/verify_pefile.c
> @@ -387,7 +387,7 @@ static int pefile_digest_pe(const void *pebuf, unsigned int pelen,
>   * verify_pefile_signature - Verify the signature on a PE binary image
>   * @pebuf: Buffer containing the PE binary image
>   * @pelen: Length of the binary image
> - * @trust_keys: Signing certificate(s) to use as starting points
> + * @trusted_keys: Signing certificate(s) to use as starting points
>   * @usage: The use to which the key is being put.
>   *
>   * Validate that the certificate chain inside the PKCS#7 message inside the PE

FYI, this was submitted earlier this week with Message-Id:

    20211004001731.26240-1-rdunlap@...radead.org

which also fixes the `Return:` notation for the return value docs.

--Ben