linux-kernel - Re: [PATCH] kunit: fix kernel-doc warnings due to mismatched arg names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFd5g44rj627arBcrUsPfTCNzK8+LaV_kqYjvdP8b77=iGVvug@mail.gmail.com>
Date:   Wed, 6 Oct 2021 10:51:51 -0700
From:   Brendan Higgins <brendanhiggins@...gle.com>
To:     Daniel Latypov <dlatypov@...gle.com>
Cc:     davidgow@...gle.com, linux-kernel@...r.kernel.org,
        kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org,
        skhan@...uxfoundation.org, Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH] kunit: fix kernel-doc warnings due to mismatched arg names

On Tue, Oct 5, 2021 at 1:46 PM Daniel Latypov <dlatypov@...gle.com> wrote:
>
> Commit 7122debb4367 ("kunit: introduce
> kunit_kmalloc_array/kunit_kcalloc() helpers") added new functions but
> called last arg `flags`, unlike the existing code that used `gfp`.
> This only is an issue in test.h, test.c still used `gfp`.
>
> But the documentation was copy-pasted with the old names, leading to
> kernel-doc warnings.
>
> Do s/flags/gfp to make the names consistent and fix the warnings.
>
> Fixes: 7122debb4367 ("kunit: introduce kunit_kmalloc_array/kunit_kcalloc() helpers")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Daniel Latypov <dlatypov@...gle.com>

Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>