lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Oct 2021 05:44:00 +0900 From: Stafford Horne <shorne@...il.com> To: Rob Herring <robh@...nel.org> Cc: Russell King <linux@...linux.org.uk>, James Morse <james.morse@....com>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Guo Ren <guoren@...nel.org>, Jonas Bonn <jonas@...thpole.se>, Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>, Michael Ellerman <mpe@...erman.id.au>, Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Yoshinori Sato <ysato@...rs.sourceforge.jp>, Rich Felker <dalias@...c.org>, x86@...nel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Florian Fainelli <f.fainelli@...il.com>, Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>, bcm-kernel-feedback-list@...adcom.com, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Frank Rowand <frowand.list@...il.com>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-csky@...r.kernel.org, openrisc@...ts.librecores.org, linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org, linux-sh@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH 06/12] openrisc: Use of_get_cpu_hwid() On Wed, Oct 06, 2021 at 11:43:26AM -0500, Rob Herring wrote: > Replace open coded parsing of CPU nodes' 'reg' property with > of_get_cpu_hwid(). > > Cc: Jonas Bonn <jonas@...thpole.se> > Cc: Stefan Kristiansson <stefan.kristiansson@...nalahti.fi> > Cc: Stafford Horne <shorne@...il.com> > Cc: openrisc@...ts.librecores.org > Signed-off-by: Rob Herring <robh@...nel.org> > --- > arch/openrisc/kernel/smp.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/openrisc/kernel/smp.c b/arch/openrisc/kernel/smp.c > index 415e209732a3..7d5a4f303a5a 100644 > --- a/arch/openrisc/kernel/smp.c > +++ b/arch/openrisc/kernel/smp.c > @@ -65,11 +65,7 @@ void __init smp_init_cpus(void) > u32 cpu_id; > > for_each_of_cpu_node(cpu) { > - if (of_property_read_u32(cpu, "reg", &cpu_id)) { > - pr_warn("%s missing reg property", cpu->full_name); > - continue; > - } > - > + cpu_id = of_get_cpu_hwid(cpu); You have defined of_get_cpu_hwid to return u64, will this create compiler warnings when since we are storing a u64 into a u32? It seems only if we make with W=3. I thought we usually warned on this. Oh well, for the openrisc bits. Acked-by: Stafford Horne <shorne@...il.com> > if (cpu_id < NR_CPUS) > set_cpu_possible(cpu_id, true); > } > -- > 2.30.2 >
Powered by blists - more mailing lists