linux-kernel - Re: [v3 PATCH 1/5] mm: hwpoison: remove the unnecessary THP check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211006040015.GA1626563@u2004>
Date:   Wed, 6 Oct 2021 13:00:15 +0900
From:   Naoya Horiguchi <naoya.horiguchi@...ux.dev>
To:     Yang Shi <shy828301@...il.com>
Cc:     naoya.horiguchi@....com, Hugh Dickins <hughd@...gle.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>,
        Peter Xu <peterx@...hat.com>,
        Oscar Salvador <osalvador@...e.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux MM <linux-mm@...ck.org>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [v3 PATCH 1/5] mm: hwpoison: remove the unnecessary THP check

> Any comment on this patch and patch #3? I'd prefer to fix more
> comments for a new version.

No. Both 1/5 and 3/5 look fine to me. So ...

> On Thu, Sep 30, 2021 at 2:53 PM Yang Shi <shy828301@...il.com> wrote:
> >
> > When handling THP hwpoison checked if the THP is in allocation or free
> > stage since hwpoison may mistreat it as hugetlb page.  After
> > commit 415c64c1453a ("mm/memory-failure: split thp earlier in memory error
> > handling") the problem has been fixed, so this check is no longer
> > needed.  Remove it.  The side effect of the removal is hwpoison may
> > report unsplit THP instead of unknown error for shmem THP.  It seems not
> > like a big deal.
> >
> > The following patch depends on this, which fixes shmem THP with
> > hwpoisoned subpage(s) are mapped PMD wrongly.  So this patch needs to be
> > backported to -stable as well.
> >
> > Cc: <stable@...r.kernel.org>
> > Suggested-by: Naoya Horiguchi <naoya.horiguchi@....com>
> > Signed-off-by: Yang Shi <shy828301@...il.com>

Acked-by: Naoya Horiguchi <naoya.horiguchi@....com>

Patch 3/5 already has my Signed-off-by, so I think it can be considered
as acked by me.

Thanks,
Naoya Horiguchi