linux-kernel - Re: [PATCH v2 2/2] serial: 8250_lpss: Enable PSE UART Auto Flow Control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6cc7b75f-1606-2150-ab51-af2922108abf@kernel.org>
Date:   Wed, 6 Oct 2021 06:46:12 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Aman Kumar <aman.kumar@...el.com>
Subject: Re: [PATCH v2 2/2] serial: 8250_lpss: Enable PSE UART Auto Flow
 Control

On 05. 10. 21, 15:30, Andy Shevchenko wrote:
> From: Aman Kumar <aman.kumar@...el.com>
> 
> Add a call to the custom ->set_termios() which has implementation about
> changing the state of RTS and CTS.

Worth noting that:
   config SERIAL_8250_LPSS
already does:
         select SERIAL_8250_DWLIB

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> Signed-off-by: Aman Kumar <aman.kumar@...el.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v2: no changes
>   drivers/tty/serial/8250/8250_lpss.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
> index 398d2c4a40e3..d3bafec7619d 100644
> --- a/drivers/tty/serial/8250/8250_lpss.c
> +++ b/drivers/tty/serial/8250/8250_lpss.c
> @@ -164,6 +164,9 @@ static int ehl_serial_setup(struct lpss8250 *lpss, struct uart_port *port)
>   	 * matching with the registered General Purpose DMA controllers.
>   	 */
>   	up->dma = dma;
> +
> +	port->set_termios = dw8250_do_set_termios;
> +
>   	return 0;
>   }
>   
> 


-- 
js
suse labs