linux-kernel - Re: [PATCH] tty: n_gsm: clean up indenting in gsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Oct 2021 07:52:03 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Zhenguo Zhao <Zhenguo.Zhao1@...soc.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] tty: n_gsm: clean up indenting in gsm_queue()

On 04. 10. 21, 12:43, Dan Carpenter wrote:
> These two lines need to be indented one more tab.

Right, the indentation is incorrect (and not the closing brace).

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
>   drivers/tty/n_gsm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index 157b51ce9cc0..3bbfcccd79d3 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -1854,8 +1854,8 @@ static void gsm_queue(struct gsm_mux *gsm)
>   				if (address_tmp == address) {
>   					for (k = j; k < addr_cnt; k++)
>   						addr_open[k] = addr_open[k+1];
> -				addr_cnt--;
> -				break;
> +					addr_cnt--;
> +					break;
>   				}
>   			}
>   		}
> 


-- 
js
suse labs