linux-kernel - Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f877a1c9-1898-23f3-bba3-3442dc1f3979@amd.com>
Date:   Wed, 6 Oct 2021 09:24:03 +0200
From:   Christian König <christian.koenig@....com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Randy Dunlap <rdunlap@...radead.org>
Cc:     akpm@...ux-foundation.org, broonie@...nel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linux-next@...r.kernel.org, mhocko@...e.cz,
        mm-commits@...r.kernel.org, Rob Clark <robdclark@...il.com>,
        Sean Paul <sean@...rly.run>, linux-arm-msm@...r.kernel.org,
        freedreno@...ts.freedesktop.org,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Intel Graphics <intel-gfx@...ts.freedesktop.org>,
        DRI <dri-devel@...ts.freedesktop.org>
Subject: Re: mmotm 2021-10-05-19-53 uploaded
 (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)



Am 06.10.21 um 09:20 schrieb Stephen Rothwell:
> Hi Randy,
>
> On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap <rdunlap@...radead.org> wrote:
>> on i386:
>>
>> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg'
>>
>>
>> Full randconfig fle is attached.
> This would be because CONFIG_DRM_MSM is set but CONFIG_COMMON_CLOCK is
> not and has been exposed by commit
>
>    b3ed524f84f5 ("drm/msm: allow compile_test on !ARM")
>
> from the drm-misc tree.

Good point, how about this change:

diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
index 5879f67bc88c..d9879b011fb0 100644
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -5,7 +5,7 @@ config DRM_MSM
         depends on DRM
         depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
         depends on IOMMU_SUPPORT
-       depends on (OF && COMMON_CLK) || COMPILE_TEST
+       depends on (OF || COMPILE_TEST) && COMMON_CLK
         depends on QCOM_OCMEM || QCOM_OCMEM=n
         depends on QCOM_LLCC || QCOM_LLCC=n
         depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n

Regards,
Christian.