linux-kernel - Re: [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d54835921f1648a4d50d8d4e160b5a12582590f.camel@pengutronix.de>
Date:   Wed, 06 Oct 2021 09:36:05 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Krzysztof Hałasa <khalasa@...p.pl>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] CONFIG_SOC_IMX6Q = i.MX6 Quad/DualLite/Solo

Am Mittwoch, dem 06.10.2021 um 08:04 +0200 schrieb Krzysztof Hałasa:
> Print i.MX6 "Solo" name in addition to the "Quad" and "DualLite"
> for SOC_IMX6Q.
> 
I don't think that's helpful, you would need to at least also print
"Dual" to make it correct. The Solo is just a fused down version of the
DualLite, just as the Dual is a fused down version of the Quad.

Quad/DualLite refers to the two different die versions of the chip.

Regards,
Lucas

> Signed-off-by: Krzysztof Hałasa <khalasa@...p.pl>
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index b407b024dde3..b6f2f2ea8e65 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -143,7 +143,7 @@ config SOC_IMX6
>  	select PL310_ERRATA_769419 if CACHE_L2X0
>  
>  config SOC_IMX6Q
> -	bool "i.MX6 Quad/DualLite support"
> +	bool "i.MX6 Quad/DualLite/Solo support"
>  	select ARM_ERRATA_764369 if SMP
>  	select ARM_ERRATA_754322
>  	select ARM_ERRATA_775420
> @@ -153,7 +153,7 @@ config SOC_IMX6Q
>  	select SOC_IMX6
>  
>  	help
> -	  This enables support for Freescale i.MX6 Quad processor.
> +	  This enables support for Freescale i.MX6 Quad/DualLite/Solo processors.
>  
>  config SOC_IMX6SL
>  	bool "i.MX6 SoloLite support"
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
> index 11dcc369ec14..8cc8a2ed1d12 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -217,7 +217,7 @@ static const char * const imx6q_dt_compat[] __initconst = {
>  	NULL,
>  };
>  
> -DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite (Device Tree)")
> +DT_MACHINE_START(IMX6Q, "Freescale i.MX6 Quad/DualLite/Solo (Device Tree)")
>  	.l2c_aux_val 	= 0,
>  	.l2c_aux_mask	= ~0,
>  	.smp		= smp_ops(imx_smp_ops),
>