linux-kernel - Re: [PATCH] firmware: xilinx: check return value of zynqmp_pm_get_api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Oct 2021 10:53:54 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Rajan Vaja <rajan.vaja@...inx.com>, <michal.simek@...inx.com>,
        <gregkh@...uxfoundation.org>, <arnd@...db.de>,
        <manish.narani@...inx.com>, <nava.manne@...inx.com>,
        <lakshmi.sai.krishna.potthuri@...inx.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firmware: xilinx: check return value of
 zynqmp_pm_get_api_version()



On 10/6/21 10:43 AM, Rajan Vaja wrote:
> Currently return value of zynqmp_pm_get_api_version() is ignored.
> Because of that, API version is checked in case of error also.
> So add check for return value of zynqmp_pm_get_api_version().
> 
> Signed-off-by: Rajan Vaja <rajan.vaja@...inx.com>
> ---
>  drivers/firmware/xilinx/zynqmp.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index a3cadba..070197e 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -1371,7 +1371,10 @@ static int zynqmp_firmware_probe(struct platform_device *pdev)
>  		return ret;
>  
>  	/* Check PM API version number */
> -	zynqmp_pm_get_api_version(&pm_api_version);
> +	ret = zynqmp_pm_get_api_version(&pm_api_version);
> +	if (ret)
> +		return ret;
> +
>  	if (pm_api_version < ZYNQMP_PM_VERSION) {
>  		panic("%s Platform Management API version error. Expected: v%d.%d - Found: v%d.%d\n",
>  		      __func__,
> 

Reviewed-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal