linux-kernel - Re: [PATCH 3/5 v3] sh: math-emu: drop unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Oct 2021 18:06:21 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Linux-sh list <linux-sh@...r.kernel.org>,
        John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Takashi YOSHII <takasi-y@....dti.ne.jp>
Subject: Re: [PATCH 3/5 v3] sh: math-emu: drop unused functions

On 10/5/21 12:26 AM, Geert Uytterhoeven wrote:
> Hi Randy,
> 
> Thanks for your patch!
> 
> On Tue, Oct 5, 2021 at 2:19 AM Randy Dunlap <rdunlap@...radead.org> wrote:
>> Delete ieee_fpe_handler() since it is not used. After that is done,
>> delete denormal_to_double() since it is not used:
>>
>> ../arch/sh/math-emu/math.c:505:12: error: 'ieee_fpe_handler' defined but not used [-Werror=unused-function]
>>    505 | static int ieee_fpe_handler(struct pt_regs *regs)
>>
>> ../arch/sh/math-emu/math.c:477:13: error: 'denormal_to_double' defined but not used [-Werror=unused-function]
>>    477 | static void denormal_to_double(struct sh_fpu_soft_struct *fpu, int n)
>>
>> Fixes: 4b565680d163 ("sh: math-emu support")
> 
> Shouldn't that be
> Fixes: 7caf62de25554da3 ("sh: remove unused do_fpu_error")
> ?

oh, ah, um. Yes, it should. Thanks!

> 
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> Gr{oetje,eeting}s,
> 
>                          Geert
> 


-- 
~Randy