linux-kernel - Re: [PATCH] memory: remove unused CONFIG_MEM_BLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <476ea5f7-53be-1a4e-c461-ff2e4a359bd0@redhat.com>
Date:   Wed, 6 Oct 2021 14:09:04 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, linux-mm@...ck.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] memory: remove unused CONFIG_MEM_BLOCK_SIZE

On 06.10.21 14:03, Lukas Bulwahn wrote:
> Commit 3947be1969a9 ("[PATCH] memory hotplug: sysfs and add/remove
> functions") defines CONFIG_MEM_BLOCK_SIZE, but this has never been
> utilized anywhere.
> 
> It is a good practice to keep the CONFIG_* defines exclusively for the
> Kbuild system. So, drop this unused definition.
> 
> This issue was noticed due to running ./scripts/checkkconfigsymbols.py.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>   include/linux/memory.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index c46ff374d48d..a216829df280 100644
> --- a/include/linux/memory.h
> +++ b/include/linux/memory.h
> @@ -143,7 +143,6 @@ typedef int (*walk_memory_blocks_func_t)(struct memory_block *, void *);
>   extern int walk_memory_blocks(unsigned long start, unsigned long size,
>   			      void *arg, walk_memory_blocks_func_t func);
>   extern int for_each_memory_block(void *arg, walk_memory_blocks_func_t func);
> -#define CONFIG_MEM_BLOCK_SIZE	(PAGES_PER_SECTION<<PAGE_SHIFT)
>   
>   extern int memory_group_register_static(int nid, unsigned long max_pages);
>   extern int memory_group_register_dynamic(int nid, unsigned long unit_pages);
> 


Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb