linux-kernel - Re: [PATCH] async_tx: correct reference to ASYNC_TX_ENABLE_CHANNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Oct 2021 21:29:22 +0800
From:   kernel test robot <lkp@...el.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Vinod Koul <vkoul@...nel.org>
Cc:     kbuild-all@...ts.01.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: Re: [PATCH] async_tx: correct reference to
 ASYNC_TX_ENABLE_CHANNEL_SWITCH

Hi Lukas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.15-rc3 next-20210922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Lukas-Bulwahn/async_tx-correct-reference-to-ASYNC_TX_ENABLE_CHANNEL_SWITCH/20211006-173543
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 02d5e016800d082058b3d3b7c3ede136cdc6ddcb
config: riscv-buildonly-randconfig-r002-20211004 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/feea9903edb75548c8beb73119676b95ca4f08ef
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lukas-Bulwahn/async_tx-correct-reference-to-ASYNC_TX_ENABLE_CHANNEL_SWITCH/20211006-173543
        git checkout feea9903edb75548c8beb73119676b95ca4f08ef
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> crypto/async_tx/async_tx.c:43:1: warning: no previous prototype for '__async_tx_find_channel' [-Wmissing-prototypes]
      43 | __async_tx_find_channel(struct async_submit_ctl *submit,
         | ^~~~~~~~~~~~~~~~~~~~~~~


vim +/__async_tx_find_channel +43 crypto/async_tx/async_tx.c

af1f951eb6ef27 Dan Williams 2009-08-29  35  
9bc89cd82d6f88 Dan Williams 2007-01-02  36  /**
47437b2c9a6431 Dan Williams 2008-02-02  37   * __async_tx_find_channel - find a channel to carry out the operation or let
9bc89cd82d6f88 Dan Williams 2007-01-02  38   *	the transaction execute synchronously
a08abd8ca890a3 Dan Williams 2009-06-03  39   * @submit: transaction dependency and submission modifiers
9bc89cd82d6f88 Dan Williams 2007-01-02  40   * @tx_type: transaction type
9bc89cd82d6f88 Dan Williams 2007-01-02  41   */
9bc89cd82d6f88 Dan Williams 2007-01-02  42  struct dma_chan *
a08abd8ca890a3 Dan Williams 2009-06-03 @43  __async_tx_find_channel(struct async_submit_ctl *submit,
9bc89cd82d6f88 Dan Williams 2007-01-02  44  			enum dma_transaction_type tx_type)
9bc89cd82d6f88 Dan Williams 2007-01-02  45  {
a08abd8ca890a3 Dan Williams 2009-06-03  46  	struct dma_async_tx_descriptor *depend_tx = submit->depend_tx;
a08abd8ca890a3 Dan Williams 2009-06-03  47  
9bc89cd82d6f88 Dan Williams 2007-01-02  48  	/* see if we can keep the chain on one channel */
9bc89cd82d6f88 Dan Williams 2007-01-02  49  	if (depend_tx &&
9bc89cd82d6f88 Dan Williams 2007-01-02  50  	    dma_has_cap(tx_type, depend_tx->chan->device->cap_mask))
9bc89cd82d6f88 Dan Williams 2007-01-02  51  		return depend_tx->chan;
729b5d1b8ec72c Dan Williams 2009-03-25  52  	return async_dma_find_channel(tx_type);
9bc89cd82d6f88 Dan Williams 2007-01-02  53  }
47437b2c9a6431 Dan Williams 2008-02-02  54  EXPORT_SYMBOL_GPL(__async_tx_find_channel);
9bc89cd82d6f88 Dan Williams 2007-01-02  55  #endif
9bc89cd82d6f88 Dan Williams 2007-01-02  56  
19242d7233df7d Dan Williams 2008-04-17  57  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (27607 bytes)