linux-kernel - Re: [PATCH MANUALSEL 5.10 1/7] selftests: KVM: Align SMCCC call with the spec in steal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YV2sVNoW8vbKrKr1@sashalap>
Date:   Wed, 6 Oct 2021 10:01:56 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Oliver Upton <oupton@...gle.com>,
        Andrew Jones <drjones@...hat.com>, shuah@...nel.org,
        kvm@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH MANUALSEL 5.10 1/7] selftests: KVM: Align SMCCC call with
 the spec in steal_time

On Wed, Oct 06, 2021 at 01:22:31PM +0200, Paolo Bonzini wrote:
>On 06/10/21 13:12, Sasha Levin wrote:
>>From: Oliver Upton <oupton@...gle.com>
>>
>>[ Upstream commit 01f91acb55be7aac3950b89c458bcea9ef6e4f49 ]
>>
>>The SMC64 calling convention passes a function identifier in w0 and its
>>parameters in x1-x17. Given this, there are two deviations in the
>>SMC64 call performed by the steal_time test: the function identifier is
>>assigned to a 64 bit register and the parameter is only 32 bits wide.
>>
>>Align the call with the SMCCC by using a 32 bit register to handle the
>>function identifier and increasing the parameter width to 64 bits.
>>
>>Suggested-by: Andrew Jones <drjones@...hat.com>
>>Signed-off-by: Oliver Upton <oupton@...gle.com>
>>Reviewed-by: Andrew Jones <drjones@...hat.com>
>>Message-Id: <20210921171121.2148982-3-oupton@...gle.com>
>>Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
>>Signed-off-by: Sasha Levin <sashal@...nel.org>
>>---
>>  tools/testing/selftests/kvm/steal_time.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>>diff --git a/tools/testing/selftests/kvm/steal_time.c b/tools/testing/selftests/kvm/steal_time.c
>>index fcc840088c91..7daedee3e7ee 100644
>>--- a/tools/testing/selftests/kvm/steal_time.c
>>+++ b/tools/testing/selftests/kvm/steal_time.c
>>@@ -120,12 +120,12 @@ struct st_time {
>>  	uint64_t st_time;
>>  };
>>-static int64_t smccc(uint32_t func, uint32_t arg)
>>+static int64_t smccc(uint32_t func, uint64_t arg)
>>  {
>>  	unsigned long ret;
>>  	asm volatile(
>>-		"mov	x0, %1\n"
>>+		"mov	w0, %w1\n"
>>  		"mov	x1, %2\n"
>>  		"hvc	#0\n"
>>  		"mov	%0, x0\n"
>>
>
>Just fixing tests, but anyway:
>
>Acked-by: Paolo Bonzini <pbonzini@...hat.com>

I'll queue up all the ones you acked, thanks!

-- 
Thanks,
Sasha