linux-kernel - Re: [PATCH next] dt-bindings: mmc: arasan,sdci: bring back requirement of clock-output-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Oct 2021 17:44:12 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH next] dt-bindings: mmc: arasan,sdci: bring back
 requirement of clock-output-names

On Mon, 4 Oct 2021 at 17:17, Krzysztof Kozlowski
<krzysztof.kozlowski@...onical.com> wrote:
>
> The schema defines dependency only of clock-output-names on #clock-cells.
> The dependency in opposite direction - requirement of clock-output-names
> if #clock-cells is defined - should be explicitly included in the
> bindings.
>
> Reported-by: Rob Herring <robh@...nel.org>
> Fixes: 22ea8ab0dcc4 ("dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>

Applied for next, thanks!

I took the liberty to squash this into the previous commit, and move
the reported-by tag into a reviewed-by tag from Rob.

Feel free to yell at me if there is something you don't like with the
squashed commit.

Kind regards
Uffe


> ---
>
> Fixes tag from the linux-next
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index dd70431df0b7..de6f076e0ece 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -158,6 +158,9 @@ properties:
>      description:
>        The MIO bank number in which the command and data lines are configured.
>
> +dependencies:
> +  '#clock-cells': [ clock-output-names ]
> +
>  required:
>    - compatible
>    - reg
> --
> 2.30.2
>