linux-kernel - Re: [PATCH] scsi: storvsc: Cap scsi_driver.can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc4b3284-0218-8a03-a55c-94c10ac0b029@huawei.com>
Date:   Wed, 6 Oct 2021 17:24:00 +0100
From:   John Garry <john.garry@...wei.com>
To:     Michael Kelley <mikelley@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "ming.lei@...hat.com" <ming.lei@...hat.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] scsi: storvsc: Cap scsi_driver.can_queue to fix a hang
 issue during boot

On 06/10/2021 17:08, Michael Kelley wrote:
>>> The calculated value of can_queue is not realistic.  The blk-mq layer
>>> caps the number of tags at 10240,
>> nit: 1024, I think
> I was thinking about BLK_MQ_MAX_DEPTH (#define'd as 10240), which
> is used to limit the tag set size in blk_mq_alloc_tag_set().   When running
> on large VMs on Hyper-V, we can see the "blk-mq: reduced tag depth
> to 10240" message.:-(

Ah, right. The other related capping is the sdev queue depth, which is 
now capped at max(1024, can_queue), see scsi_device_max_queue_depth().

Thanks,
John