linux-kernel - Re: [PATCH 3/3] ASoC: Intel: sof_rt5682: use id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd7A4yjA+BN_4PwCNNSyy=JbGTDh7U6FdacRYLYPJaYCQ@mail.gmail.com>
Date:   Wed, 6 Oct 2021 19:46:47 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Brent Lu <brent.lu@...el.com>
Cc:     ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        Yong Zhi <yong.zhi@...el.com>,
        Vamshi Krishna Gopal <vamshi.krishna.gopal@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rander Wang <rander.wang@...el.com>,
        Bard Liao <bard.liao@...el.com>,
        Malik_Hsu <malik_hsu@...tron.corp-partner.google.com>,
        Libin Yang <libin.yang@...el.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Paul Olaru <paul.olaru@....nxp.com>,
        Curtis Malainey <cujomalainey@...omium.org>,
        Mac Chiang <mac.chiang@...el.com>,
        Gongjun Song <gongjun.song@...el.com>
Subject: Re: [PATCH 3/3] ASoC: Intel: sof_rt5682: use id_alt to enumerate rt5682s

On Wed, Oct 6, 2021 at 7:23 PM Brent Lu <brent.lu@...el.com> wrote:
>
> Use the id_alt field to enumerate rt5682s headphone codec and remove
> redundant entries in tables.

...

> +static struct snd_soc_acpi_codecs adl_rt5682s_hp = {
> +       .num_codecs = 1,
> +       .codecs = {"RTL5682"}

Keeping commas in non-terminator entries is always good to avoid churn
in the future.

> +};

...

> +static struct snd_soc_acpi_codecs rt5682s_hp = {
> +       .num_codecs = 1,
> +       .codecs = {"RTL5682"}

Ditto.

> +};

...

> +static struct snd_soc_acpi_codecs rt5682s_hp = {
> +       .num_codecs = 1,
> +       .codecs = {"RTL5682"}

Ditto.

> +};

...

> +static struct snd_soc_acpi_codecs rt5682s_hp = {
> +       .num_codecs = 1,
> +       .codecs = {"RTL5682"}

Ditto.

> +};

...

> +static struct snd_soc_acpi_codecs rt5682s_hp = {
> +       .num_codecs = 1,
> +       .codecs = {"RTL5682"}

Ditto.

> +};

...and so on.

-- 
With Best Regards,
Andy Shevchenko