linux-kernel - Re: [PATCH v2] memory: fsl_ifc: fix leak of irq and nand_irq in fsl_ifc_ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163363216363.76978.10999134270437599845.b4-ty@canonical.com>
Date:   Thu,  7 Oct 2021 20:42:44 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Dongliang Mu <mudongliangabcd@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Prabhakar Kushwaha <prabhakar@...escale.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] memory: fsl_ifc: fix leak of irq and nand_irq in fsl_ifc_ctrl_probe

On Sat, 25 Sep 2021 23:14:32 +0800, Dongliang Mu wrote:
> The error handling code of fsl_ifc_ctrl_probe is problematic. When
> fsl_ifc_ctrl_init fails or request_irq of fsl_ifc_ctrl_dev->irq fails,
> it forgets to free the irq and nand_irq. Meanwhile, if request_irq of
> fsl_ifc_ctrl_dev->nand_irq fails, it will still free nand_irq even if
> the request_irq is not successful.
> 
> Fix this by refactoring the error handling code
> 
> [...]

Applied, thanks!

[1/1] memory: fsl_ifc: fix leak of irq and nand_irq in fsl_ifc_ctrl_probe
      commit: 4ed2f3545c2e5acfbccd7f85fea5b1a82e9862d7

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>