linux-kernel - [PATCH 1/2] objtool: Optimize re-writing jump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211007212626.950220936@infradead.org>
Date:   Thu, 07 Oct 2021 23:22:12 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     jpoimboe@...hat.com
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org, mbenes@...e.cz
Subject: [PATCH 1/2] objtool: Optimize re-writing jump_label

There's no point to re-write the jump_label NOP when it's already a NOP.

Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
---
 tools/objtool/check.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1397,7 +1397,7 @@ static int handle_jump_alt(struct objtoo
 		return -1;
 	}
 
-	if (special_alt->key_addend & 2) {
+	if ((special_alt->key_addend & 2) && orig_insn->type != INSN_NOP) {
 		struct reloc *reloc = insn_reloc(file, orig_insn);
 
 		if (reloc) {