lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Oct 2021 19:22:45 -0600 From: David Ahern <dsahern@...il.com> To: Leonard Crestez <cdleonard@...il.com>, Jakub Kicinski <kuba@...nel.org>, Shuah Khan <shuah@...nel.org>, David Ahern <dsahern@...nel.org> Cc: "David S. Miller" <davem@...emloft.net>, Ido Schimmel <idosch@...dia.com>, Seth David Schoen <schoen@...alty.org>, netdev@...r.kernel.org, linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 08/11] selftests: net/fcnal: Replace sleep after server start with -k On 10/6/21 3:35 PM, Leonard Crestez wrote: > > I counted the [FAIL] or [ OK ] markers but not the output of nettest > itself. I don't know what to look for, I guess I could diff the outputs? > > Shouldn't it be sufficient to compare the exit codes of the nettest client? mistakes happen. The 700+ tests that exist were verified by me when I submitted the script - that each test passes when it should and fails when it should. "FAIL" has many reasons. I tried to have separate exit codes for nettest.c to capture the timeouts vs ECONNREFUSED, etc., but I could easily have made a mistake. scanning the output is the best way. Most of the 'supposed to fail' tests have a HINT saying why it should fail. > > The output is also modified by a previous change to not capture server > output separately and instead let it be combined with that of the > client. That change is required for this one, doing out=$(nettest -k) > does not return on fork unless the pipe is also closed. > > I did not look at your change, mine is relatively minimal because it > only changes who decide when the server goes into the background: the > shell script or the server itself. This makes it work very easily even > for tests with multiple server instances. The logging issue is why I went with 1 binary do both server and client after nettest.c got support for changing namespaces.
Powered by blists - more mailing lists