linux-kernel - Re: [PATCH] Revert "serial: 8250: Fix reporting real baudrate value in c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YV8CavX93a8XCSJP@kroah.com>
Date:   Thu, 7 Oct 2021 16:21:30 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Jiri Slaby <jirislaby@...nel.org>, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH] Revert "serial: 8250: Fix reporting real baudrate value
 in c_ospeed field"

On Thu, Oct 07, 2021 at 03:31:46PM +0200, Johan Hovold wrote:
> This reverts commit 32262e2e429cdb31f9e957e997d53458762931b7.
> 
> The commit in question claims to determine the inverse of
> serial8250_get_divisor() but failed to notice that some drivers override
> the default implementation using a get_divisor() callback.
> 
> This means that the computed line-speed values can be completely wrong
> and results in regular TCSETS requests failing (the incorrect values
> would also be passed to any overridden set_divisor() callback).
> 
> Similarly, it also failed to honour the old (deprecated) ASYNC_SPD_FLAGS
> and would break applications relying on those when re-encoding the
> actual line speed.
> 
> There are also at least two quirks, UART_BUG_QUOT and an OMAP1510
> workaround, which were happily ignored and that are now broken.
> 
> Finally, even if the offending commit were to be implemented correctly,
> this is a new feature and not something which should be backported to
> stable.
> 
> Cc: Pali Rohár <pali@...nel.org>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/tty/serial/8250/8250_port.c | 17 -----------------
>  1 file changed, 17 deletions(-)

Argh, sorry I missed this, good catch.  I'll go queue this up now,
thanks.

greg k-h