linux-kernel - Re: [PATCH] rk3399-nanopi4.dtsi: enable sdmmc regulator on boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YV8DTqA/6XI9KZmK@sirena.org.uk>
Date:   Thu, 7 Oct 2021 15:25:18 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Trevor Woerner <twoerner@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Javier Martinez Canillas <javierm@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>, Chen-Yu Tsai <wens@...e.org>,
        Peter Robinson <pbrobinson@...il.com>,
        Robin Murphy <robin.murphy@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        "open list:ARM/Rockchip SoC support" 
        <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH] rk3399-nanopi4.dtsi: enable sdmmc regulator on boot

On Wed, Oct 06, 2021 at 12:08:17PM -0400, Trevor Woerner wrote:
> @@ -71,6 +71,7 @@ vcc3v0_sd: vcc3v0-sd {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&sdmmc0_pwr_h>;
>  		regulator-always-on;
> +		regulator-boot-on;

This shouldn't be required for devices that can read their status, the
fact that it's always on should cause it to be powered up if it wasn't
already when applying constraints.  I'm therefore confused as to what
this change is doing and there's probably something else going on here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)