linux-kernel - Re: [PATCH net-next] flow_offload: add l4 port range match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR18MB400926F5F6A79AAFACC8C552B2B19@SJ0PR18MB4009.namprd18.prod.outlook.com>
Date:   Thu, 7 Oct 2021 14:57:10 +0000
From:   "Volodymyr Mytnyk [C]" <vmytnyk@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>, Chris Mi <cmi@...dia.com>,
        Roi Dayan <roid@...dia.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] flow_offload: add l4 port range match

Hi Jakub,

> > From: Volodymyr Mytnyk <vmytnyk@...vell.com>
> > 
> > Current flow offload API doen't allow to offload l4 port range
> > match dissector (FLOW_DISSECTOR_KEY_PORTS_RANGE) in the driver,
> > as is no relevant data struct that will hold this information
> > and pass it to the driver.
> > 
> > Thus, to make offload of l4 port range possible by other drivers
> > add dedicated dissector port range struct to get min and max
> > value provided by user.
> > 
> > - add flow_dissector_key_ports_range to store
> >   l4 port range match.
> > - add flow_match_ports_range key/mask
> > 
> > tc cmd example:
> >     tc qd add dev PORT clsact
> >     tc filter add dev PORT protocol ip ingress \
> >         flower skip_sw ip_proto udp src_port 2-37 action drop
> > 
> > Signed-off-by: Volodymyr Mytnyk <vmytnyk@...vell.com>
> 
> A driver implementation needs to be posted in the same series.
> Otherwise it's an API with no in-tree user. Let's consider this
> posting an RFC.
>
Ok, thanks for the comment. Will post RFC with driver code usage included.

Regards,
Volodymyr