linux-kernel - Re: [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION (MCP79)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALjTZvYZcDS5HB=3h8u68jaTRNTXENQGV96reOeDS544fVceew@mail.gmail.com>
Date:   Thu, 7 Oct 2021 17:13:43 +0100
From:   Rui Salvaterra <rsalvaterra@...il.com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     tglx@...utronix.de, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [REGRESSION][BISECTED] 5.15-rc1: Broken AHCI on NVIDIA ION (MCP79)

Hi, Marc,

On Thu, 7 Oct 2021 at 16:03, Marc Zyngier <maz@...nel.org> wrote:
>
> Duh. Make that:
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index dc7741431bf3..89c7c99cd1bb 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -5798,6 +5798,6 @@ DECLARE_PCI_FIXUP_CLASS_HEADER(0x1ac1, 0x089a,
>
>  static void nvidia_ion_ahci_fixup(struct pci_dev *pdev)
>  {
> -       pdev->dev_flags |= PCI_MSI_FLAGS_MASKBIT;
> +       pdev->dev_flags |= PCI_DEV_FLAGS_HAS_MSI_MASKING;
>  }
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x0ab8, nvidia_ion_ahci_fixup);
>
>         M.
>
> --

The previous patch with this fixup on top also fixes the problem for
me. No issues on the GPU side (other than the existing ones, due to
NVIDIA uncooperativeness, regarding nouveau). Feel free to add my

Tested-by: Rui Salvaterra <rsalvaterra@...il.com>

Thanks,
Rui