linux-kernel - Re: [PATCH v1 2/2] i2c:busses:Read and Write routines for PCI1XXXX I2C module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Oct 2021 19:15:10 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     LakshmiPraveen Kopparthi <LakshmiPraveen.Kopparthi@...rochip.com>,
        wsa@...nel.org, andriy.shevchenko@...ux.intel.com,
        treding@...dia.com, mirq-linux@...e.qmqm.pl, s.shtylyov@....ru,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v1 2/2] i2c:busses:Read and Write routines for PCI1XXXX
 I2C module

05.10.2021 11:48, LakshmiPraveen Kopparthi пишет:
> On Wed, 2021-09-29 at 10:20 +0300, Dmitry Osipenko wrote:
>> [Some people who received this message don't often get email from
>> digetx@...il.com. Learn why this is important at 
>> http://aka.ms/LearnAboutSenderIdentification.]
>>
>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>> know the content is safe
>>
>> 29.09.2021 09:22, LakshmiPraveen Kopparthi пишет:
>>> Read and Write callbacks for PCI1XXXX I2C adapter is added.
>>>
>>> Signed-off-by: LakshmiPraveen Kopparthi <
>>> LakshmiPraveen.Kopparthi@...rochip.com>
>>> ---
>>>  drivers/i2c/busses/i2c-mchp-pci1xxxx.c | 485
>>> +++++++++++++++++++++++++
>>>  1 file changed, 485 insertions(+)
>>
>> Why this is a separate patch?
> 
> I thought of splitting the driver into two patches.
> 1. Contains the intialisations,ISR, supend and resume callbacks.
> 2. Contains read and write functions.
> If it make sense to merge these into a single patch, I will do it.  

Please combine it all into a single patch. In general it's better to
have a single patch for new drivers since it's easier to review.