linux-kernel - Re: [PATCH] ACPI: tools: fix compilation error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 7 Oct 2021 19:19:53 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Miguel Bernal Marin <miguel.bernal.marin@...ux.intel.com>
Cc:     Rafael J Wysocki <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
        Robert Moore <robert.moore@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@...ica.org>
Subject: Re: [PATCH] ACPI: tools: fix compilation error

On Wed, Oct 6, 2021 at 7:13 AM Miguel Bernal Marin
<miguel.bernal.marin@...ux.intel.com> wrote:
>
> When acpi tools are compiled the following error is showed:
>
>    $ cd tools/power/acpi
>    $ make
>      DESCEND tools/acpidbg
>      MKDIR    include
>      CP       include
>      CC       tools/acpidbg/acpidbg.o
>    In file included from /home/linux/tools/power/acpi/include/acpi/platform/acenv.h:152,
>                     from /home/linux/tools/power/acpi/include/acpi/acpi.h:22,
>                     from acpidbg.c:9:
>    /home/linux/tools/power/acpi/include/acpi/platform/acgcc.h:25:10: fatal error: linux/stdarg.h: No such file or directory
>       29 | #include <linux/stdarg.h>
>          |          ^~~~~~~~~~~~~~~~
>    compilation terminated.
>
> Keep the same logic from ACPICA, just identify when is used inside kernel
> or by acpi tool.
>
> Fixes: c0891ac15f04 ("isystem: ship and use stdarg.h")
> Signed-off-by: Miguel Bernal Marin <miguel.bernal.marin@...ux.intel.com>
> ---
>  include/acpi/platform/acgcc.h | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/include/acpi/platform/acgcc.h b/include/acpi/platform/acgcc.h
> index fb172a03a753..20ecb004f5a4 100644
> --- a/include/acpi/platform/acgcc.h
> +++ b/include/acpi/platform/acgcc.h
> @@ -22,9 +22,14 @@ typedef __builtin_va_list va_list;
>  #define va_arg(v, l)            __builtin_va_arg(v, l)
>  #define va_copy(d, s)           __builtin_va_copy(d, s)
>  #else
> +#ifdef __KERNEL__
>  #include <linux/stdarg.h>
> -#endif
> -#endif
> +#else
> +/* Used to build acpi tools */
> +#include <stdarg.h>
> +#endif /* __KERNEL__ */
> +#endif /* ACPI_USE_BUILTIN_STDARG */
> +#endif /* ! va_arg */
>
>  #define ACPI_INLINE             __inline__
>
> --

Applied as 5.16 material, thanks!