linux-kernel - Re: [PATCH v2 1/2] iio: health: afe4403: Make use of the helper function dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211007183338.37c80008@jic23-huawei>
Date:   Thu, 7 Oct 2021 18:33:38 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>, <linux-iio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] iio: health: afe4403: Make use of the helper
 function dev_err_probe()

On Tue, 28 Sep 2021 09:44:01 +0800
Cai Huoqing <caihuoqing@...du.com> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
Series applied and pushed out as testing for 0-day to see if it can
find anything we missed.

Thanks,

Jonathan

> ---
> v1->v2: Remove the separate line of PTR_ERR().
> 
>  drivers/iio/health/afe4403.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c
> index d4921385aaf7..3a8cfb669b25 100644
> --- a/drivers/iio/health/afe4403.c
> +++ b/drivers/iio/health/afe4403.c
> @@ -487,10 +487,10 @@ static int afe4403_probe(struct spi_device *spi)
>  	}
>  
>  	afe->regulator = devm_regulator_get(afe->dev, "tx_sup");
> -	if (IS_ERR(afe->regulator)) {
> -		dev_err(afe->dev, "Unable to get regulator\n");
> -		return PTR_ERR(afe->regulator);
> -	}
> +	if (IS_ERR(afe->regulator))
> +		return dev_err_probe(afe->dev, PTR_ERR(afe->regulator),
> +				     "Unable to get regulator\n");
> +
>  	ret = regulator_enable(afe->regulator);
>  	if (ret) {
>  		dev_err(afe->dev, "Unable to enable regulator\n");